Ticket #16 (enhancement)
Opened 2 years ago
Last modified 1 year ago
Client/Order State Field not long enough
Status: closed (fixed)
| Reported by: | brieb | Assigned to: | brieb |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.7 |
| Component: | phpbms | Version: | 0.61 |
| Keywords: | Cc: | ||
Some countries use more than a two letter abbreviation for state/province/region. We should increase this to 5 chars
Attachments
Change History
10/12/06 09:52:33: Modified by brieb
- keywords set to review.
10/12/06 09:52:55: Modified by brieb
- type changed from defect to enhancement.
- milestone changed from unknown to 0.62.
10/12/06 10:21:31: Modified by brieb
- status changed from new to assigned.
10/13/06 12:10:51: Modified by brieb
- milestone changed from 0.62 to 0.70.
10/16/06 00:39:21: Modified by brieb
- description changed.
- summary changed from Client/Order State Fileds not long enough to Client/Order State Field not long enough.
12/28/06 13:38:16: Modified by brieb
- keywords deleted.
- status changed from assigned to closed.
- resolution set to fixed.
Implemented by [178]. Went with a length of 5, as no other input was given.
01/01/07 13:38:51: Modified by jayson.barker@gmail.com
Hello,
I am aware you have closed this ticket, however i feel that a length of 5 is still too short, In the UK for example there are many counties that have far longer names, it is quite important to include the full name of the county as we do not abbreviate.
I would propose a limit of 15-20, as there are counties with names like Buckinghamshire,Northamptonshire,West Midlands.
Im not sure what other counties are like for province names.
Regards Jay
01/02/07 10:59:19: Modified by anonymous
- status changed from closed to reopened.
- resolution deleted.
01/02/07 20:52:17: Modified by brieb
- status changed from reopened to closed.
- resolution set to fixed.
We are open to this idea. However, why don't you open a new ticket (like extending from 5 - 15 to 20) so that we can include this one in the upcoming release of 0.7
Also, you can assign the task to yourself, and submit a patch with the necessary changes to extend it to 15 characters. Use [178] as a guide of what/where it needs to changed in order to support this. Hopefully we can get this change in for milestone 0.8
10/24/07 10:58:17: Modified by anonymous
- status changed from closed to reopened.
- type changed from enhancement to defect.
- version changed from 0.61 to 0.7.
- resolution deleted.
I am using v0.7 but cannot seem to get more than 5 characters. I have used the guide in [178] and everything is set as it should be, even when maxlength="5" changed to 20 in invoices_addedit.php and clients_addedit.php it still wont let me have more than 5 characters.
Any help much appreciated.
10/24/07 11:12:59: Modified by brieb
- status changed from reopened to closed.
- type changed from defect to enhancement.
- version changed from 0.7 to 0.61.
- resolution set to fixed.
If you notice , the change also alters the database in addition to changing the HTML field lengths.
Also the best place to get help is to use the forum.
I'm also wondering if we should change the state to an autofill, or drop down list of some sort. Comments or thoughts?